Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Present content first in References Treeview #180653

Closed
jooyoungseo opened this issue Apr 23, 2023 · 6 comments · Fixed by #182115
Closed

[Accessibility]: Present content first in References Treeview #180653

jooyoungseo opened this issue Apr 23, 2023 · 6 comments · Fixed by #182115
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders references-viewlet
Milestone

Comments

@jooyoungseo
Copy link

jooyoungseo commented Apr 23, 2023

CC @meganrogge @isidorn

  1. Create test.py with the following content:
x = 1
x = 2
x = 3
  1. Locate your cursor at x and press Shift+F12.

Current Output

symbol in test.py on line 1 at column 1, x = 1

Suggested Output

x = 1 in test.py on line 1 at column 1

  • Note: the word 'symbol' is not needed here.
@isidorn
Copy link
Contributor

isidorn commented Apr 24, 2023

Good feedback for references tree. I think this is a low hanging change in the AccessibilityTreeProvider.
Assigning to @jrieken

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Apr 24, 2023
@jrieken jrieken added references-viewlet help wanted Issues identified as good community contribution opportunities labels Apr 24, 2023
@jrieken
Copy link
Member

jrieken commented Apr 24, 2023

Code pointer:

result.contextValue = 'reference-item';

@jooyoungseo
Copy link
Author

jooyoungseo commented Apr 26, 2023

@jrieken and @meganrogge While this seems a good chance for community contribution, accessibility issues and its impact need more attention than people think and must not be put on the back burner. This issue has been long-standing and not trivial, negatively impacting the productivity to those having to consume information via speech.

@meganrogge
Copy link
Contributor

I agree @jooyoungseo - what github does not show you is that I had moved this to my planning category of my Github project so I will work on it soon

@jooyoungseo
Copy link
Author

Thanks, @meganrogge ! I apologize if I was out of line. I had to act as an accessibility evangelist.

@meganrogge
Copy link
Contributor

meganrogge commented Apr 26, 2023

All good 😄 no apologies necessary

@meganrogge meganrogge added this to the May 2023 milestone May 10, 2023
meganrogge added a commit that referenced this issue May 10, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders references-viewlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants