Revert change to always update status

[Tyriar]

Just saw #180903, this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.

[karrtikr]

@Tyriar I'm not clear on the solution. There're a limited number of Terminal Status IDs:

vscode/src/vs/workbench/contrib/terminal/browser/terminalStatusList.ts

Lines 21 to 27 in 9b32200

	export const enum TerminalStatus {
	Bell = 'bell',
	Disconnected = 'disconnected',
	RelaunchNeeded = 'relaunch-needed',
	EnvironmentVariableInfoChangesActive = 'env-var-info-changes-active',
	ShellIntegrationAttentionNeeded = 'shell-integration-attention-needed'
	}

In this case status ID hasn't changed, it's still EnvironmentVariableInfoChangesActive, only the description which comes with it has updated.

[Tyriar]

@karrtikr working on it, I'll send a PR to you in a bit

[karrtikr]

Verification steps:

Validate #180851 still doesn't happen.