Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on function in hidden lines info bar reveals unrelated code from above #199328

Closed
alexdima opened this issue Nov 28, 2023 · 0 comments · Fixed by #202266
Closed

Clicking on function in hidden lines info bar reveals unrelated code from above #199328

alexdima opened this issue Nov 28, 2023 · 0 comments · Fixed by #202266
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
December / Januar...

Comments

@alexdima
Copy link
Member

Testing #199155

  • create a diff where there are many hidden lines
  • click on a function symbol
  • 🐛 the function guessIndentation is not shown
  • I would have expected to reveal the function that I click and not the code above the function
Kapture.2023-11-28.at.13.45.20.mp4
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues labels Nov 28, 2023
@hediet hediet added this to the December / January 2024 milestone Jan 11, 2024
hediet added a commit that referenced this issue Jan 11, 2024
@hediet
Fixes #199328
8e3a3b8
@hediet hediet mentioned this issue Jan 11, 2024
Merged
hediet added a commit that referenced this issue Jan 11, 2024
@hediet
Fixes #199328
4d2d058
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 11, 2024
@benibenj benibenj added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

Fixes #199328 microsoft/vscode
5 participants
@hediet @alexdima @benibenj @aiday-mar @vscodenpa