Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Show all" is bad action title #199348

Closed
isidorn opened this issue Nov 28, 2023 · 2 comments · Fixed by #199507
Closed

"Show all" is bad action title #199348

isidorn opened this issue Nov 28, 2023 · 2 comments · Fixed by #199507
Assignees
@hediet
Labels
diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone
November 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 28, 2023

Testing #199155

"Show all" is very generic. Can we have a more precise title message of the action.
For example "Show unchanged region", "Expand unchanged region"...

Screenshot 2023-11-28 at 14 53 22
@hediet hediet added polish Cleanup and polish issue diff-editor Diff editor issues labels Nov 28, 2023
@hediet
Copy link
Member

hediet commented Nov 28, 2023

That's how github does it:

Image

I like "Show unchanged region" though.

@hediet hediet added this to the November 2023 milestone Nov 28, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Nov 28, 2023

Ok, I think we can be better than GitHub here :)
And make sure to use right capitalisation of words.

@hediet hediet mentioned this issue Nov 29, 2023
Merged
hediet added a commit that referenced this issue Nov 29, 2023
@hediet
Fixes #199348
889e275
hediet added a commit that referenced this issue Nov 29, 2023
@hediet
Merge pull request #199507 from microsoft/hediet/b/steep-jaguar
c4e2473 
Fixes #199348
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

Fixes #199348 microsoft/vscode
3 participants
@isidorn @hediet @vscodenpa