Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test: Terminal - Terminal Persistence - detach/attach - should persist buffer content #216464

Open
hediet opened this issue Jun 18, 2024 · 9 comments · Fixed by #224414 or #224525
Open
Assignees
Labels
smoke-test-failure terminal Integrated terminal issues
Milestone

Comments

@hediet
Copy link
Member

hediet commented Jun 18, 2024

  1. VSCode Smoke Tests (Electron)
    Terminal
    Terminal Persistence
    detach/attach
    should persist buffer content:
    Error: Timeout: get element '.quick-input-widget' after 20 seconds.
    at Code.poll (/Users/runner/work/1/s/test/automation/out/code.js:204:23)
    at async Code.waitForElement (/Users/runner/work/1/s/test/automation/out/code.js:163:16)
    at async QuickInput.waitForQuickInputClosed (/Users/runner/work/1/s/test/automation/out/quickinput.js:32:9)
    at async Terminal.runCommandWithValue (/Users/runner/work/1/s/test/automation/out/terminal.js:109:9)
    at async Context. (out/areas/terminal/terminal-persistence.test.js:64:17)

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=278997&view=logs&j=260a512b-e5ca-5cf1-3f8e-20c0fa41efc9&t=dc7a7a05-ae89-521b-55db-0cb2ded34668

@meganrogge meganrogge added terminal Integrated terminal issues smoke-test-failure labels Jun 18, 2024
@meganrogge meganrogge modified the milestone: July 2024 Jun 18, 2024
@Tyriar Tyriar modified the milestones: July 2024, August 2024 Jul 22, 2024
@meganrogge
Copy link
Contributor

meganrogge commented Jul 31, 2024

1) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Persistence
           detach/attach
             should persist buffer content:
     Error: Timeout: get terminal buffer '#terminal .terminal-wrapper' after 20 seconds.
      at Code.poll (D:\a\_work\1\s\test\automation\out\code.js:204:23)
      at async Code.waitForTerminalBuffer (D:\a\_work\1\s\test\automation\out\code.js:175:9)
      at async Terminal.waitForTerminalText (D:\a\_work\1\s\test\automation\out\terminal.js:262:13)
      at async Context.<anonymous> (out\areas\terminal\terminal-persistence.test.js:68:17)

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=286027&view=results

@meganrogge
Copy link
Contributor

meganrogge commented Jul 31, 2024

Fails bc of line wrapping differences

Before detaching:

Image

After attaching:

Image

@meganrogge
Copy link
Contributor

meganrogge commented Jul 31, 2024

i think we should change the test so that it removes \n from the resultant string

meganrogge added a commit that referenced this issue Jul 31, 2024
meganrogge added a commit that referenced this issue Jul 31, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
Copy link

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@meganrogge
Copy link
Contributor

still seeing a failure 🤔

Image

@meganrogge
Copy link
Contributor

wondering if we also need to match \r for windows

@meganrogge meganrogge reopened this Aug 1, 2024
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 1, 2024
meganrogge added a commit that referenced this issue Aug 1, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 1, 2024
@alexr00 alexr00 reopened this Aug 2, 2024
@alexr00
Copy link
Member

alexr00 commented Aug 2, 2024

Looks like it's still failing. Skipping to unblock the build.

@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2024
alexr00 added a commit that referenced this issue Aug 2, 2024
BABA983 pushed a commit to BABA983/vscode that referenced this issue Aug 2, 2024
@meganrogge
Copy link
Contributor

Thanks @alexr00

@meganrogge meganrogge removed this from the August 2024 milestone Aug 2, 2024
@meganrogge
Copy link
Contributor

I'm out of ideas for how to fix this, think it should remain skipped to prevent build failures

@meganrogge meganrogge added this to the Backlog milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-test-failure terminal Integrated terminal issues
Projects
None yet
4 participants