Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.codeActionsOnSave conflict "tslint.autoFixOnSave": true, #49370

Closed
Giancarlo1974 opened this issue May 7, 2018 · 2 comments
Closed

editor.codeActionsOnSave conflict "tslint.autoFixOnSave": true, #49370

Giancarlo1974 opened this issue May 7, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone

Comments

@Giancarlo1974
Copy link

visual studio code
Versione 1.23.0
Commit 7c7da59
Data 2018-05-03T16:44:55.614Z
Shell 1.7.12
Renderer 58.0.3029.110
Nodo 7.9.0
Architettura x64

Windows 10

Steps to Reproduce:

  1. file -> preference

// Place your settings in this file to overwrite the default settings
{
"workbench.colorTheme": "Visual Studio Dark",
"php.validate.executablePath": "C:/xampp/php/php.exe",
"php.executablePath": "C:/xampp/php/php.exe",
"php.suggest.basic": true,
"workbench.iconTheme": "vscode-great-icons",
"workbench.startupEditor": "newUntitledFile",
"php.memoryLimit": "2048M",
"typescript.check.tscVersion": false,
"workbench.startupEditor": "newUntitledFile",
"window.zoomLevel": 1,
"editor.tabSize": 2,
"editor.detectIndentation": false,
"editor.insertSpaces": true,
// Consente di configurare le impostazioni dell'editor di cui eseguire l'override per il linguaggio [yaml].
"[vue]": {
"editor.insertSpaces": true,
"editor.tabSize": 2
},
"javascript.format.insertSpaceBeforeFunctionParenthesis": true,
"terminal.integrated.shell.windows": "C:\WINDOWS\System32\cmd.exe",
"prettier.singleQuote": true,
"prettier.eslintIntegration": true,
"git.ignoreMissingGitWarning": true,
"search.exclude": {
"/node_modules": true,
"
/bower_components": true,
"/dist": true
},
"typescript.referencesCodeLens.enabled": true,
"tslint.ignoreDefinitionFiles": false,
"tslint.autoFixOnSave": true,
"tslint.exclude": "
/node_modules/**/",
/

"editor.codeActionsOnSave": {
"source.organizeImports": true
},
*/
"telemetry.enableTelemetry": false
}

  1. in any ts file, i try to write
    //...
    i got the tslint error:
    [tslint] comment must start with a space (comment-format)

if i try to save, the editor fix the problem:
// ...

  1. Now i enable

"editor.codeActionsOnSave": {
"source.organizeImports": true
},

the autofix function doesn't fix

@vscodebot
Copy link

vscodebot bot commented May 7, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the php PHP support issues label May 7, 2018
@mjbvz mjbvz assigned mjbvz and egamma and unassigned roblourens May 7, 2018
@mjbvz mjbvz added javascript JavaScript support issues and removed php PHP support issues labels May 7, 2018
@egamma egamma added this to the May 2018 milestone May 8, 2018
egamma added a commit to microsoft/vscode-tslint that referenced this issue May 25, 2018
@egamma
Copy link
Member

egamma commented May 25, 2018

Fix will be in 1.0.30

@egamma egamma closed this as completed May 25, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 25, 2018
@chrmarti chrmarti added the verified Verification succeeded label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants