Stop shipping core languages out of the box

[ramya-rao-a]

Related to #45663

We would like to have insiders running without core languages for at least one milestone before going to stable. If translations team is ready, we can start 1.25.insiders without core languages and ship 1.25 stable without them.

• Remove core languages from the build
• Remove the prompt to download core language pack. This will be taken by the recommendation that @ramya-rao-a implemented.

[dbaeumer]

@danyeh FYI. We plan to ship the June release without translations.

[sandy081]

@danyeh Let us know if all core language packs are available in the Market place so that we can go ahead and remove core languages from insiders build

[dbaeumer]

OK. I generated new builds and now the installation of the language pack is correctly proposed. For example I get:

if I start code with --locale=ru

@ramya-rao-a I not want to restart the whole discussion however now seeing this I think that it might be valuable to have some English text in this notification as well. The user might not be able to speak Russian and the rest of the UI is English.

[dbaeumer]

@sandy081 & @ramya-rao-a can you test the latest builds from the dbaeumer/50588 branch on Mac & Linux and let me know if they behave OK for you?

[dbaeumer]

@sandy081 & @ramya-rao-a were you able to test it. I would like to merge the branch back into master after getting your OK.

[sandy081]

Yeah, I tested the build.

• Recommendation prompts are shown correctly
• On install and restart VS Code is shown in UI language

[dbaeumer]

@ramya-rao-a any comment regarding #50588 (comment)

I will merge the PR over to master. We can still address the string issue discussed in #50588 (comment)

[sandy081]

Agreed. Lets merge it to master and release new insiders for today. We can address issues as we see.

[ramya-rao-a]

@dbaeumer We could add the string in both languages, but then the message will become a very loooong string.

Currently, the message is something like:
VS Code is available in {0}. Please install the language pack to change the display language.
VS Code is available in {0}. Search for language packs in the Marketplace to get started.

Maybe we can shorten it to
To change the display language to {0}, please install the language pack.
To change the display language to {0}, search for language packs in the Marketplace.

[dbaeumer]

I see the point but shorting it by a couple of characters will not making a big difference. Could we fold the English text?

[ramya-rao-a]

It doesn't look like much of a difference in English above, but am sure, once translated there would be a noticeable difference.

What do you mean by "folding the English text"?

[dbaeumer]

Having a twisty in front that folds the second to nth line.

[waldyrious]

Is this the right place to track the necessary changes to documentation mentioned in #45663? Or would that be tracked as a separate issue?

[ramya-rao-a]

@dbaeumer The notification service takes only strings. So I don't see how we can show twists and fold lines.

How about this:

(The bulgarian msg will be smaller once the updated string goes through translations)

For languages whose language pack do not have the translation needed to show the prompt:

If the above is ok, then feel free to merge the PR #52706

[ramya-rao-a]

@sandy081 I've created a PR to remove the prompt about core language support in the future. Please take a look. #52827

With that, we can close this issue.

[dbaeumer]

Closing the issue then.