First cut at unifying notebook renderers apis #123738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the api described in #123540. Major points: - Instead of having the `markdown-it` renderer pull it its dependencies, instead the dependencies can call `getRenderer` to import the object returned by the `markdown-it` renderer - We try to detect if a renderer is using the old or new api. Old renderers are still run as globals while new ones are loaded with `import` - I have only hooked up the new API for markdown renderers so far
connor4312
reviewed
May 13, 2021
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
Outdated
Show resolved
Hide resolved
connor4312
reviewed
May 13, 2021
src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts
Show resolved
Hide resolved
connor4312
reviewed
May 13, 2021
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
Outdated
Show resolved
Hide resolved
connor4312
reviewed
May 13, 2021
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
Outdated
Show resolved
Hide resolved
- Fix mis-used dependencies. Add the roughly proposed 'extends' model for notebook renderers. Keep it out of contribution schema for now until we can work it more. - Made new loading work with JS modules. - Consolidated the 'old style' code in the renderer so that we can just delete it when the time comes. - Removed duplicated code and sharp edges from the 'queue' mechaism.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the api described in #123540. Major points:
Instead of having the
markdown-itrenderer pull it its dependencies (such askatex), now the dependencies can callgetRendererto import the object returned by themarkdown-itrendererWe try to detect if a renderer is using the old or new api. Old renderers are still run as globals while new ones are loaded with
importI have only hooked up the new API for markdown renderers so far