Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the Opacity level #139963

Closed
wants to merge 2 commits into from
Closed

Edited the Opacity level #139963

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2021

This PR fixes #137270

@@ -96,7 +96,7 @@
text-align: center;
height: 12px;
line-height: 12px;
opacity: 0.5;
opacity: 0.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of the issue is that the opacity needs to be increased, not decreased.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback.
Yes, I changed that.

@dbaeumer dbaeumer assigned mjbvz and unassigned dbaeumer Jan 1, 2022
@mjbvz mjbvz added this to the February 2022 milestone Jan 27, 2022
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jan 28, 2022

I'd maybe remove the opacity all together as we're working on removing this from our code base because of accessibility issues. Here's what it looks like without any opacity tweaks:

CleanShot 2022-01-28 at 13 32 33@2x

cc @mjbvz

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 31, 2022

Closing this since the user seems to have deleted their account

@mjbvz mjbvz closed this Jan 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The foreground here is very dark, hope we can allow us to modify it ourselves
5 participants