Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inlay hints displayStyle #145470

Merged
merged 4 commits into from
Mar 30, 2022
Merged

feat: inlay hints displayStyle #145470

merged 4 commits into from
Mar 30, 2022

Conversation

jhgg
Copy link
Contributor

@jhgg jhgg commented Mar 19, 2022 •
edited
Loading

fixes #145191

This PR implements "compact" inlay hint display style, which removes the padding/border radius/vertical alignment as discussed in #145191

@ghost
Copy link

ghost commented Mar 19, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jhgg jhgg mentioned this pull request Mar 19, 2022
Closed
@jhgg jhgg force-pushed the feat/inlay-hints-compact-mode branch from 491b18d to b34c46d Compare March 19, 2022 22:44
@jhgg jhgg changed the title feat: inlay hints displayMode feat: inlay hints displayStyle Mar 19, 2022
@jhgg jhgg force-pushed the feat/inlay-hints-compact-mode branch from b34c46d to 4a38a7a Compare March 19, 2022 22:48
jogo-
jogo- reviewed Mar 20, 2022
View reviewed changes
src/vs/monaco.d.ts Outdated Show resolved Hide resolved
@jrieken jrieken added this to the April 2022 milestone Mar 21, 2022
jrieken
jrieken approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrieken
Copy link
Member

jrieken commented Mar 30, 2022

Thanks. I am going ahead and I am merging this. We also want to trigger some feedback and will run with compact mode as default for the next weeks of insiders. If folks like it might become the default, we also consider to tweak the font size to be same as the editor font size

@jrieken jrieken merged commit b9e538d into microsoft:main Mar 30, 2022
jrieken referenced this pull request Mar 31, 2022
@alexdima
Fix hygiene issues
c36a527
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jogo- jogo- jogo- left review comments

@jrieken jrieken jrieken approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
April 2022
Development

Successfully merging this pull request may close these issues.

an option for more compact inlay hints
3 participants
@jhgg @jrieken @jogo-