Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JS from titlebar #169866

Merged
merged 7 commits into from
Dec 28, 2022
Merged

Remove JS from titlebar #169866

merged 7 commits into from
Dec 28, 2022

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Dec 22, 2022 •
edited
Loading

Known pre-existing issue #169865

Note about zoom behavior: the titlebar will remain a fixed size (ignoring zoom) when:

  • The zoom is below 100% and we have window controls being displayed
  • or, on desktop, the only content of the titlebar is the title (no interactive controls)

@sbatten sbatten self-assigned this Dec 22, 2022
@vscodenpa vscodenpa added this to the January 2023 milestone Dec 22, 2022
bpasero
bpasero approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 tested on Windows, also with zooming, seems to work great.

@sbatten
Copy link
Member Author

sbatten commented Dec 28, 2022

Will merge to keep the PR lifespan from extending. @jrieken feel free to provide additional feedback when you are back

@sbatten sbatten merged commit 8b51173 into main Dec 28, 2022
@sbatten sbatten deleted the sbatten/outdoor-mosquito branch December 28, 2022 20:23
@kieferrm kieferrm mentioned this pull request Jan 2, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@jrieken jrieken Awaiting requested review from jrieken

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@sbatten @bpasero @vscodenpa