Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize TerminalWordLinkDetector._parseWords #169889

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Optimize TerminalWordLinkDetector._parseWords #169889

merged 3 commits into from
Dec 27, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 23, 2022

Fixes #169867

Before:

image

After:

image

@Tyriar Tyriar added this to the January 2023 milestone Dec 23, 2022
@Tyriar Tyriar self-assigned this Dec 23, 2022
bpasero
bpasero previously approved these changes Dec 23, 2022
@bpasero
Copy link
Member

bpasero commented Dec 23, 2022

@Tyriar looks like test failures

@Tyriar Tyriar merged commit 048752c into main Dec 27, 2022
@Tyriar Tyriar deleted the tyriar/169867 branch December 27, 2022 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[perf] Investigate TerminalLinkDetector#_parseWords performance
3 participants