Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let notebook renderers throw error to fallback to next mime type #171567

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Let notebook renderers throw error to fallback to next mime type #171567

merged 1 commit into from
Jan 18, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 18, 2023

For #171562

By throwing an error with the name vscode.fallbackToNextRenderer, we will fallback to the other mime data on the output item

@mjbvz mjbvz added this to the January 2023 milestone Jan 18, 2023
@mjbvz mjbvz self-assigned this Jan 18, 2023
@mjbvz mjbvz enabled auto-merge (squash) January 18, 2023 01:34
@DonJayamanne
Copy link
Contributor

an error with the name vscode.fallbackToNextRenderer, we will fallback to the other mime data on the output

Hopefully once this API is stable, we can have a concrete error class that we can throw, similar to CancellationError

@DonJayamanne
Copy link
Contributor

Oh wait, there's no way to change that in the future as this isn't guarded by any Proposed API isn't it

@mjbvz mjbvz merged commit d8568bb into microsoft:main Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @DonJayamanne