Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update to Electron 25.2.0 #187402

Closed
wants to merge 2 commits into from

Conversation

AaronDewes
Copy link

@AaronDewes AaronDewes commented Jul 9, 2023

I noticed the latest VSCode was no longer able to access secrets properly on KDE Neon Unstable, which is using a preview of KDE 6.

Looking through the logs, I noticed the desktop environment was detected as KDE 4. This is because the underlying Chromium version of Electron 22 did not support KDE 6 yet.

This update to Electron (and because of that, Chromium), adds full support for KDE 6.

@AaronDewes
Copy link
Author

@microsoft-github-policy-service agree

AaronDewes added a commit to AaronDewes/vscode-docs that referenced this pull request Jul 9, 2023
Related to microsoft/vscode#187402, this makes the necessary docs change.
@bhavyaus bhavyaus assigned deepak1556 and unassigned bhavyaus Jul 10, 2023
@deepak1556
Copy link
Collaborator

Thanks for the contribution, we don't accept runtime updates from external contributions since there are tasks that cannot be completed by community. This will be resolved with #180466

@deepak1556 deepak1556 closed this Jul 11, 2023
gregvanl pushed a commit to microsoft/vscode-docs that referenced this pull request Jul 12, 2023
* Add more information about KDE 6

Related to microsoft/vscode#187402, this makes the necessary docs change.

* Update settings-sync.md

* Update settings-sync.md
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants