Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TS/JS to use organize imports codeAction instead of command #47850

Merged
merged 4 commits into from
Apr 18, 2018
Merged

Move TS/JS to use organize imports codeAction instead of command #47850

merged 4 commits into from
Apr 18, 2018

Commits on Apr 17, 2018

  1. Move TS/JS to use organize imports code action 

    Fixes microsoft#47845
Fixes microsoft#46647

- Defines a new standard `SourceOrganizeImports` `CodeActionKind` to be used to implement organize imports in a consistent way.
- Add a new `Organize imports` command and keybinding that executes these actions.
- Move over the existing js/ts organize imports command to use the new code action kind
    @mjbvz
    mjbvz committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    6fdb5c3 View commit details
    Browse the repository at this point in the history

  2. Use supportedCodeActions context key

    @mjbvz
    mjbvz committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9970349 View commit details
    Browse the repository at this point in the history

  3. Document code action kind values

    @mjbvz
    mjbvz committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    378c760 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Fix regular expression 

    Make sure we only match whole scopes and not `unicorn.source.organizeImports`
    @mjbvz
    mjbvz committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e9f5378 View commit details
    Browse the repository at this point in the history