Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning when returned code action will be dropped #55090

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Log warning when returned code action will be dropped #55090

merged 3 commits into from
Jul 26, 2018

Commits on Jul 25, 2018

  1. Add extension logging when returned code action will be dropped 

    Fixes microsoft#54803

Adds a loggin warning when a code action provider returns code actions that will be dropped. Warn in the the following cases:

- A provider returns code actions (not commands)
- And a specific code action type is requested.
- And the returned code actions either don't set kind or are of the wrong kind
    @mjbvz
    mjbvz committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    e0f3928 View commit details
    Browse the repository at this point in the history

  2. Use log service

    @mjbvz
    mjbvz committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a69bdf7 View commit details
    Browse the repository at this point in the history

  3. Include extension id in warning

    @mjbvz
    mjbvz committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    ccbdd8e View commit details
    Browse the repository at this point in the history