Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #97498. Fallback to default value for translate3d #97629

Merged
merged 1 commit into from
May 13, 2020

Conversation

rebornix
Copy link
Member

This PR fixes #97498

To verify the fix, run Code with flag --show-mac-overlay-borders, for example, code-insider --show-mac-overlay-borders

Before the fix
image

After the fix: please note the the file explorer now has a gray border, which indicates it's in its own layer
image

The other way to verify is to inspect the element and see if monaco-list-rows has transform: translate3d(0, 0, 0).

@rebornix rebornix merged commit 69094ef into release/1.45 May 13, 2020
@rebornix rebornix deleted the rebornix/fix-list-view-default-translate3d branch May 13, 2020 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants