Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make async VSTestConsoleWrapper apis obsolete #4648

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Aug 8, 2023

Fix #4592

VSTest console wrapper apis are not following the rules of good async APIs, they don't internally use the async apis for communication, and start session just plain does not work because it awaits before it attempts to connect.

We don't have a plan to fix them, and would have to change the public apis when we do this redesign, marking them as obsolete, with one exception of the postProcessingAsync API which does not have a sync equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async APIs not working
2 participants