This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
System.Diagnostics.Process has a different behavior on non-Windows platforms #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndows platforms. - The Process.[StartTime/ExitTime] throw `System.ComponentModel.Win32Exception` on Linux. The API is exposing OS information that is not available once the process exits.
brianrob
reviewed
Nov 16, 2017
| StartTime = process.StartTime; | ||
| ExitTime = process.ExitTime; | ||
|
|
||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) |
There was a problem hiding this comment.
The change here seems reasonable to me, but I think rather than special casing Windows, just do the same thing on all platforms. Otherwise, our methodology is different between operating systems, and that makes both the harness and data interpretation more complicated.
…but the APIs measured data.
brianrob
approved these changes
Nov 16, 2017
johnbeisner
pushed a commit
to johnbeisner/sdk
that referenced
this pull request
Jan 9, 2018
johnbeisner
added a commit
to dotnet/sdk
that referenced
this pull request
Jan 24, 2018
* First draft enabling performance tests... * Disabling tests for non-Windows... * Updates... * Missing "\" * Set 'DefaultIterations' to "1" * Resolved BUG: microsoft/xunit-performance#248 * Fixing typos... * Formatting, variable names changes. * Fixing a typo...
johnbeisner
pushed a commit
to dotnet/sdk
that referenced
this pull request
Jan 30, 2018
* First draft enabling performance tests... * Resolved BUG: microsoft/xunit-performance#248
johnbeisner
pushed a commit
to dotnet/sdk
that referenced
this pull request
Feb 7, 2018
* First draft enabling performance tests... * Disabling tests for non-Windows... * Updates... * Missing "\" * Set 'DefaultIterations' to "1" * Resolved BUG: microsoft/xunit-performance#248 * Fixing typos... * Formatting, variable names changes. * Fixing a typo...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process.StartTimethrowSystem.ComponentModel.Win32Exceptionon Linux because the data is not available once the process exits.