fix: content range order during upload (#304)

fileuploader/large_file_upload_task.go

@@ -9,7 +9,6 @@ import (
 	"os"
 	"strconv"
 	"strings"
-	"sync"
 	"time"
 )
 
@@ -57,28 +56,19 @@ func (l *largeFileUploadTask[T]) Upload(progress ProgressCallBack) UploadResult[
 	var itemResponse T
 	var location *string
 
-	var wg sync.WaitGroup
-	wg.Add(len(slices))
-
 	for _, slice := range slices {
-		uploadSlice := slice
-		go func() {
-			defer wg.Done()
-			response, uploadLocation, err := l.uploadWithRetry(uploadSlice, maxRetriesPerRequest)
-			if err != nil {
-				responseErrors = append(responseErrors, err)
-			} else {
-				progress(uploadSlice.RangeEnd, uploadSlice.TotalSessionLength)
-			}
-			if response != nil {
-				itemResponse = response.(T)
-			}
-			location = uploadLocation
-		}()
+		response, uploadLocation, err := l.uploadWithRetry(slice, maxRetriesPerRequest)
+		if err != nil {
+			responseErrors = append(responseErrors, err)
+		} else {
+			progress(slice.RangeEnd, slice.TotalSessionLength)
+		}
+		if response != nil {
+			itemResponse = response.(T)
+		}
+		location = uploadLocation
 	}
 
-	wg.Wait()
-
 	if len(responseErrors) > 0 {
 		result.SetUploadSucceeded(false)
 		result.SetResponseErrors(responseErrors)

fileuploader/large_file_upload_test.go

@@ -64,8 +64,13 @@ func TestLargeFileUploadTask(t *testing.T) {
 	// verify that the object was created correctly
 	// verify the number of sub upload tasks
 	progressCall := 0
+	var previousValue int64 = 0
 	progress := func(progress int64, total int64) {
 		progressCall++
+		if previousValue > progress {
+			assert.Fail(t, "progress should not decrease")
+		}
+		previousValue = progress
 	}
 	result := uploader.Upload(progress)