Skip to content

Commit

Permalink
Remove slurpRemainder TODO from (*ZoneParser).Next (#1508)
Browse files Browse the repository at this point in the history
No one has complained about this in the four years it's been here. I
think we can safely accept this new behaviour.
  • Loading branch information
tmthrgd authored Nov 7, 2023
1 parent a16092f commit 5d3f81b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,6 @@ func (zp *ZoneParser) Next() (RR, bool) {
if !isPrivate && zp.c.Peek().token == "" {
// This is a dynamic update rr.

// TODO(tmthrgd): Previously slurpRemainder was only called
// for certain RR types, which may have been important.
if err := slurpRemainder(zp.c); err != nil {
return zp.setParseError(err.err, err.lex)
}
Expand Down

0 comments on commit 5d3f81b

Please sign in to comment.