Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LICENSE file #10

Closed
jawnsy opened this issue Sep 26, 2016 · 4 comments
Closed

Missing LICENSE file #10

jawnsy opened this issue Sep 26, 2016 · 4 comments

Comments

@jawnsy
Copy link
Contributor

jawnsy commented Sep 26, 2016

Dear maintainer,

Thanks for your awesome DNS library and accompanying examples!

I noticed the source code headers refer to a LICENSE file, but none is included in this repository.

Cheers,

Jonathan

@miekg
Copy link
Owner

miekg commented Sep 26, 2016

indeed! These where once part of the godns, but they've split of. This should be a https://opensource.org/licenses/BSD-2-Clause

@jawnsy
Copy link
Contributor Author

jawnsy commented Sep 26, 2016

@miekg Should this just be a copy of https://github.com/miekg/dns/blob/master/LICENSE ?

I can submit a PR if that would help :)

@miekg
Copy link
Owner

miekg commented Sep 27, 2016

[ Quoting notifications@github.com in "Re: [miekg/exdns] Missing LICENSE f..." ]

@miekg Should this just be a copy of https://github.com/miekg/dns/blob/master/LICENSE

I can submit a PR if that would help :)

Yes please do :-) Except it does not need to the Google Authors.
Anyway just submit a PR I'll brush it up after #lazy

Thanks!

/Miek

Miek Gieben

@miekg miekg closed this as completed in #11 Sep 27, 2016
miekg pushed a commit that referenced this issue Sep 27, 2016
This adds a license file with the BSD 2-Clause license.  It also
updates the README to add a build status badge, and a badge for
the license.

Closes: #10
@jawnsy
Copy link
Contributor Author

jawnsy commented Sep 27, 2016

Bah, sorry! Turns out I should've tested first, the license badge isn't working. Will fix in a follow-up PR.

Tested this time here: https://github.com/jawnsy/licensetest

(Seems to be a little finicky with the way the text is formatted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants