Add RSA AES key wrap mechanism parameters #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varder
changed the title
|
Hi @miekg, |
miekg
reviewed
Feb 2, 2023
params.go
Outdated
| @@ -26,6 +26,11 @@ static inline void putECDH1PublicParams(CK_ECDH1_DERIVE_PARAMS_PTR params, CK_VO | |||
| params->pPublicData = pPublicData; | |||
| params->ulPublicDataLen = ulPublicDataLen; | |||
| } | |||
|
|
|||
| static inline void putRsaAesKeyWrapParams(CK_RSA_AES_KEY_WRAP_PARAMS_PTR params, CK_VOID_PTR pOAEPParams) | |||
There was a problem hiding this comment.
Suggested change
| static inline void putRsaAesKeyWrapParams(CK_RSA_AES_KEY_WRAP_PARAMS_PTR params, CK_VOID_PTR pOAEPParams) | |
| static inline void putRSAAESKeyWrapParams(CK_RSA_AES_KEY_WRAP_PARAMS_PTR params, CK_VOID_PTR pOAEPParams) |
to keep in-line with the usage of RSA and AES in this pkg
miekg
reviewed
Feb 2, 2023
params.go
Outdated
| @@ -188,3 +193,23 @@ func cECDH1DeriveParams(p *ECDH1DeriveParams, arena arena) ([]byte, arena) { | |||
|
|
|||
| return memBytes(unsafe.Pointer(¶ms), unsafe.Sizeof(params)), arena | |||
| } | |||
|
|
|||
| type RsaAesKeyWrapParams struct { | |||
miekg
reviewed
Feb 2, 2023
params.go
Outdated
| OAEPParams OAEPParams | ||
| } | ||
|
|
||
| func cRsaAesKeyWrapParams(p *RsaAesKeyWrapParams, arena arena) ([]byte, arena) { |
|
some style stuff, otherwise lgtm |
pkcs11-spec-v3.1-cs01
6.1.23 RSA AES KEY WRAP
The RSA AES key wrap mechanism based on the RSA public-key
cryptosystem and the AES key wrap mechanism. It supports
single-part key wrapping and key unwrapping.
How to use:
params := &pkcs11.RSAAESKeyWrapParams{
AESKeyBits: 256,
OAEPParams: pkcs11.OAEPParams{
HashAlg: pkcs11.CKM_SHA256,
MGF: pkcs11.CKG_MGF1_SHA256,
SourceType: pkcs11.CKZ_DATA_SPECIFIED,
},
}
mechanism := []*pkcs11.Mechanism {
pkcs11.NewMechanism(pkcs11.CKM_RSA_AES_KEY_WRAP, params)
}
unwrappedKey, err := ctx.UnwrapKey(session, mechanism, wrappingKeyObj,
wrappedKey, unwrappedKeyAttributes)
Signed-off-by: Valerii Chubar <valerii_chubar@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanism implementation:
OP-TEE/optee_os#5647
pkcs11-spec-v3.1-cs01
6.1.23 RSA AES KEY WRAP
The RSA AES key wrap mechanism based on the RSA public-key cryptosystem and the AES key wrap mechanism. It supports single-part key wrapping and key unwrapping.
How to use: