fix some corner cases

mike-north · Nov 17, 2016 · a4d9ac0 · a4d9ac0
1 parent b2386bd
commit a4d9ac0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/addon/core/transition-data.js b/addon/core/transition-data.js
@@ -48,7 +48,9 @@ prototype.routeFinishedSetup = function routeFinishedSetup(route) {
 };
 
 prototype._viewAdded = function _viewAdded(view, index) {
-  this._lastActivatedRoute.views.push(index);
+  if (this._lastActivatedRoute && this._lastActivatedRoute.views) {
+    this._lastActivatedRoute.views.push(index);
+  }
 };
 
 export default TransitionData;
diff --git a/addon/services/ember-perf.js b/addon/services/ember-perf.js
@@ -79,10 +79,13 @@ export default Base.extend(Evented, {
       destRoute: transitionRoute
     });
     transitionInfo.promise.then(() => {
-      this.transitionData.finish();
+    }).catch(() => {
+    }).finally(() => {
       let event = this.transitionData;
+
       scheduleOnce('afterRender', () => {
         this.trigger('transitionComplete', event);
+        this.transitionData.finish();
       });
     });
   },
@@ -179,4 +182,4 @@ export default Base.extend(Evented, {
       console.groupEnd();
     }
   })
-});
+});