Omit password in debug (syslog) output #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration files may contain it, but those can be protected with filesystem permissions. Debug log, however, may end up in syslog(3) which is usually accessible by all users on a system. Avoid disclosing user secrets by simply not printing the password.
|
Reminded by #1809 copy/pasting debug ouput containing besaid |
|
Nice one, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration files may contain it, but those can be protected with filesystem permissions.
Debug log, however, may end up in syslog(3) which is usually accessible by all users on a system.
Avoid disclosing user secrets by simply not printing the password.