Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stricter filtering of check run completion events (actions#2520)
I observed that 100% of canceled jobs in my runner pool were not causing scale down events. This PR fixes that. The problem was caused by actions#2119. actions#2119 ignores certain webhook events in order to fix actions#2118. However, actions#2119 overdoes it and filters out valid job cancellation events. This PR uses stricter filtering and add visibility for future troubleshooting. <details><summary>Example cancellation event</summary> This is the redacted top portion of a valid cancellation event my runner pool received and ignored. ```json { "action": "completed", "workflow_job": { "id": 12848997134, "run_id": 4738060033, "workflow_name": "slack-notifier", "head_branch": "auto-update/slack-notifier-0.5.1", "run_url": "https://api.github.com/repos/nuru/<redacted>/actions/runs/4738060033", "run_attempt": 1, "node_id": "CR_kwDOB8Xtbc8AAAAC_dwjDg", "head_sha": "55bada8f3d0d3e12a510a1bf34d0c3e169b65f89", "url": "https://api.github.com/repos/nuru/<redacted>/actions/jobs/12848997134", "html_url": "https://github.com/nuru/<redacted>/actions/runs/4738060033/jobs/8411515430", "status": "completed", "conclusion": "cancelled", "created_at": "2023-04-19T00:03:12Z", "started_at": "2023-04-19T00:03:42Z", "completed_at": "2023-04-19T00:03:42Z", "name": "build (arm64)", "steps": [ ], "check_run_url": "https://api.github.com/repos/nuru/<redacted>/check-runs/12848997134", "labels": [ "self-hosted", "arm64" ], "runner_id": 0, "runner_name": "", "runner_group_id": 0, "runner_group_name": "" }, ``` </details>
- Loading branch information