Make api resources more beautiful #559
Conversation
| @@ -318,7 +318,7 @@ | |||
| } | |||
| ], | |||
| 'acceptable_blood_groups': [ | |||
| 'A', 0 | |||
| 'A', '0' | |||
There was a problem hiding this comment.
Tohle tam bylo schválně abychom si uměli poradit i s číslem když by to tak někdo náhodou poslal.
| @@ -53,7 +53,7 @@ | |||
| RECIPIENTS = [ | |||
| { | |||
| 'acceptable_blood_groups': [ | |||
| 'A', 0 | |||
| 'A', '0' | |||
There was a problem hiding this comment.
nechas tam teda aspon nekdy tu 0?
There was a problem hiding this comment.
nebo to ted hezky nejde? Jako ve swaggeru to nevyzadujeme, je dulezity abychom zvladli jak 0 tak O ale nemusime asi zvladat int, to je mozna zbytecne obecny.
There was a problem hiding this comment.
Níže v tomhle file tu 0 na několika místech nechávám
| @@ -51,7 +51,8 @@ | |||
|
|
|||
| RecipientJson = patient_api.model('Recipient', { | |||
| 'db_id': fields.Integer(required=True, description='Database id of the patient'), | |||
| 'acceptable_blood_groups': fields.List(required=False, cls_or_instance=fields.Nested(BloodGroupEnumJson)), | |||
| 'acceptable_blood_groups': fields.List(required=False, cls_or_instance=fields.Nested(BloodGroupEnumJson), | |||
| example=['A', '0']), | |||
There was a problem hiding this comment.
ten example asi je hezci delat pres blood group enum ne?
| @@ -69,4 +59,5 @@ def post(self, txm_event_id: int) -> str: | |||
| :configuration.max_matchings_to_show_to_viewer] | |||
| calculated_matchings_dto.show_not_all_matchings_found = False | |||
| logging.debug('Collected matchings and sending them') | |||
| return jsonify(calculated_matchings_dto) | |||
| dataclasses.asdict(calculated_matchings_dto) | |||
| return response_ok(calculated_matchings_dto) | |||
There was a problem hiding this comment.
to dataclasses tam davat nemusis ne? V response ok volas jsonify?
There was a problem hiding this comment.
dataclasses jsem tam zapomněl z testování. Ano, v response ok je jsonify a může se to v budoucnu nahradit tím marshalling.
def response_ok(data, code=200):
return make_response(jsonify(data), code)
| @@ -30,7 +30,7 @@ | |||
| } | |||
| }, | |||
| "200": { | |||
| "description": "Success.", | |||
| "description": "Success", | |||
There was a problem hiding this comment.
Protože jsem odstranil description='Success.' a 'Success' je zřejmě nějaká default hodnota flasku. Mít description Success u response_ok mi připadá zbytečné.
|
|
||
| def response_error_matching_not_found(self): | ||
| model = self._create_fail_response_model() | ||
| return self.response(code=404, model=model, description='Matching for provided id was not found.') |
There was a problem hiding this comment.
nemame ted nastaveny ten kod na nekolika mistech? Vzdy tohle jsme nejak meli reseny v tom hladnlovani erroriu?
There was a problem hiding this comment.
Tohle je to, co jsme měli napsané u každé routy a je to jen kvůli dokumentaci swaggeru.
There was a problem hiding this comment.
me tenhle kod mate cely ten soubor namespaces, kdyz mame jeste error_handler.py kterej taky nejak probublava do swaggeru, mam pocit ze je tady divna duplicita. Muzem si zavolat dyztak.
There was a problem hiding this comment.
Jak jsme se domluvili na callu, vytvořil jsem na tohle issue #590
|
Chapu PR #562 spravne tak, ze jsi tady vypnul nejaky testy a zas se maji zapnout v tamtom PR? |
…ces_more_beautiful # Conflicts: # txmatching/web/swagger/swagger.json
…ces_more_beautiful
Closes #500