Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

491 make migrations and sql achemy database consistent #940

Merged
merged 6 commits into from
Jul 26, 2022
Merged

491 make migrations and sql achemy database consistent #940

merged 6 commits into from
Jul 26, 2022

Conversation

jogobeny
Copy link
Contributor

@jogobeny jogobeny commented Jul 21, 2022 •
edited
Loading

Fixes #491 consistency, not approach to ensure consistency each migration.

@kubantjan Should default_txm_event_id be a foreign key? In case of yes, I'd need to create txm_event(id=1) in prepare_app_for_tests.DbTests.setUp before add_users().

@jogobeny jogobeny linked an issue Jul 21, 2022 that may be closed by this pull request
Make migrations and SQL Achemy database consistent #491
Closed
@kubantjan
Copy link
Member

kubantjan commented Jul 22, 2022 •
edited
Loading

Fixes #491 consistency, not approach to ensure consistency each migration.

@kubantjan Should default_txm_event_id be a foreign key? In case of yes, I'd need to create txm_event(id=1) in prepare_app_for_tests.DbTests.setUp before add_users().

yes makes sense to alter the tests like you say, create some txm event first then

kubantjan
kubantjan requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good! reply to your question plus one tiny comment

.isort.cfg Outdated Show resolved Hide resolved
@jogobeny jogobeny force-pushed the 491-make-migrations-and-sql-achemy-database-consistent branch 2 times, most recently from b956b52 to 3abe63d Compare July 22, 2022 14:48
@jogobeny jogobeny requested a review from kubantjan July 22, 2022 15:01
kristinagalik
kristinagalik approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@kristinagalik kristinagalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

za mna fajn @kubantjan :)

@kubantjan kubantjan force-pushed the 491-make-migrations-and-sql-achemy-database-consistent branch from 3abe63d to 58c3fbb Compare July 26, 2022 08:54
@kubantjan kubantjan merged commit 394c125 into master Jul 26, 2022
@kubantjan kubantjan deleted the 491-make-migrations-and-sql-achemy-database-consistent branch July 26, 2022 09:31
@jogobeny jogobeny mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubantjan kubantjan kubantjan approved these changes

@kristinagalik kristinagalik kristinagalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make migrations and SQL Achemy database consistent
3 participants
@jogobeny @kubantjan @kristinagalik