Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: roll back apimachinery to v0.28.6 #30398

Merged
merged 1 commit into from
Feb 1, 2024
Merged

enhance: roll back apimachinery to v0.28.6 #30398

merged 1 commit into from
Feb 1, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 31, 2024 •
edited by congqixia
Loading

apimachinery use go 1.21 in v0.29.0
reference issue: golang/go#62409

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file labels Jan 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jan 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Jan 31, 2024

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (060c860) 80.31% compared to head (46f1e73) 80.28%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30398      +/-   ##
==========================================
- Coverage   80.31%   80.28%   -0.03%     
==========================================
  Files         966      966              
  Lines      136666   136666              
==========================================
- Hits       109761   109728      -33     
- Misses      23189    23220      +31     
- Partials     3716     3718       +2

see 14 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Jan 31, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 31, 2024
@jaime0815
Copy link
Contributor

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Feb 1, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
enhance: roll back apimachinery to v0.28.6
46f1e73 
apimachinery use go 1.21 in v0.29.0
reference issue: golang/go#62409

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 1, 2024
@mergify mergify bot added the ci-passed label Feb 1, 2024
congqixia
congqixia approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit adaf270 into milvus-io:master Feb 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@jaime0815 jaime0815

@congqixia congqixia

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunby @jaime0815 @sre-ci-robot @congqixia