enhance: Seal by total growing segments size #34692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…7-sealByGrowingSize
sre-ci-robot
added
size/L
mergify
bot
added
dco-passed
…7-sealByGrowingSize
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34692 +/- ##
==========================================
+ Coverage 71.65% 79.92% +8.27%
==========================================
Files 1160 1160
Lines 140889 140926 +37
==========================================
+ Hits 100955 112638 +11683
+ Misses 35580 23935 -11645
+ Partials 4354 4353 -1
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
overall looks good me, better to change the config to a better name |
bigsheeper
added a commit
to bigsheeper/milvus
that referenced
this pull request
Jul 18, 2024
Seals the largest growing segment if the total size of growing segments of each shard exceeds the size threshold(default 4GB). Introducing this policy can help keep the size of growing segments within a suitable level, alleviating the pressure on the delegator. issue: milvus-io#34554 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 19, 2024
Seals the largest growing segment if the total size of growing segments of each shard exceeds the size threshold(default 4GB). Introducing this policy can help keep the size of growing segments within a suitable level, alleviating the pressure on the delegator. issue: #34554 pr: #34692 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seals the largest growing segment if the total size of growing segments of each shard exceeds the size threshold(default 4GB). Introducing this policy can help keep the size of growing segments within a suitable level, alleviating the pressure on the delegator.
issue: #34554