Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rename config of sealing by growing segmetns size #34787

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 18, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Contributor

czs007 commented Jul 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (e4e18cb) to head (5518ca8).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34787       +/-   ##
===========================================
- Coverage   84.44%   69.80%   -14.65%     
===========================================
  Files         892     1170      +278     
  Lines      117033   142440    +25407     
===========================================
+ Hits        98832    99431      +599     
- Misses      13832    38584    +24752     
- Partials     4369     4425       +56     
Files Coverage Δ
internal/datacoord/segment_allocation_policy.go 90.99% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.53% <100.00%> (+<0.01%) ⬆️

... and 301 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit b22e549 into milvus-io:master Jul 19, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants