Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Avoid panic due to nil schema #35063

Merged
merged 2 commits into from
Jul 30, 2024
Merged

enhance: Avoid panic due to nil schema #35063

merged 2 commits into from
Jul 30, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

issue: #25620

@bigsheeper
enhance: Avoid panic due to nil schema
71c5d1c 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
update
d41144f 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Jul 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 29, 2024
This was referenced Jul 29, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 29, 2024
@bigsheeper
enhance: Avoid panic due to nil schema (#35063) (#35064)
cc188fb 
/kind improvement

issue: #25620

pr: #35063

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
Copy link
Contributor Author

rerun ut

@czs007 czs007 merged commit 39d2593 into milvus-io:master Jul 30, 2024
7 of 10 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 30, 2024
@bigsheeper
enhance: Avoid panic due to nil schema (#35063) (#35065)
289336a 
/kind improvement

issue: #25620

pr: #35063

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@bigsheeper @sumitd2
enhance: Avoid panic due to nil schema (milvus-io#35063)
9ef2840 
/kind improvement

issue: milvus-io#25620

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @sre-ci-robot @czs007