-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Avoid unnecessary compaction #35148
Conversation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35148 +/- ##
==========================================
- Coverage 84.90% 81.68% -3.22%
==========================================
Files 938 1211 +273
Lines 119028 143317 +24289
==========================================
+ Hits 101059 117075 +16016
- Misses 13545 21836 +8291
+ Partials 4424 4406 -18
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Estimate the import segment size based on DiskSegmentMaxSize(2G) to avoid unnecessary compaction after import completed. issue: milvus-io#35147 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Estimate the import segment size based on DiskSegmentMaxSize(2G) to avoid unnecessary compaction after import completed.
issue: #35147