Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add import option to skip disk quota check #35274

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

bigsheeper
Copy link
Contributor

Add an option to skip the disk quota check for backup-restore import.

issue: #33775

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 5, 2024
@czs007
Copy link
Contributor

czs007 commented Aug 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@c22b0a6). Learn more about missing BASE report.
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35274   +/-   ##
=========================================
  Coverage          ?   72.45%           
=========================================
  Files             ?     1215           
  Lines             ?   142767           
  Branches          ?        0           
=========================================
  Hits              ?   103443           
  Misses            ?    34909           
  Partials          ?     4415           
Files Coverage Δ
internal/datacoord/import_util.go 90.80% <100.00%> (ø)
internal/util/importutilv2/option.go 68.42% <100.00%> (ø)

@sre-ci-robot sre-ci-robot merged commit b71e058 into milvus-io:master Aug 5, 2024
14 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 6, 2024
Add an option to skip the disk quota check for backup-restore import.

issue: #33775

pr: #35274

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Add an option to skip the disk quota check for backup-restore import.

issue: milvus-io#33775

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants