enhance: Append drop partition msg to wal #35326
Conversation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35326 +/- ##
==========================================
+ Coverage 81.54% 84.84% +3.29%
==========================================
Files 1217 944 -273
Lines 143785 119471 -24314
==========================================
- Hits 117256 101363 -15893
+ Misses 22100 13684 -8416
+ Partials 4429 4424 -5
|
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…8-streaming-ddl
| var singleton *walAccesserImpl = nil | ||
| var singleton WALAccesser = nil | ||
|
|
||
| func SetWAL(w WALAccesser) { |
There was a problem hiding this comment.
move it into a test-build only file?
| @@ -19,8 +23,8 @@ func Init(c *clientv3.Client) { | |||
|
|
|||
| // Release releases the resources of the wal accesser. | |||
| func Release() { | |||
| if singleton != nil { | |||
| singleton.Close() | |||
| if w, ok := singleton.(*walAccesserImpl); ok && w != nil { | |||
There was a problem hiding this comment.
Suggest adding a close method to the WALAccesser interface and invoking it directly.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
add create partition msg to wal in the next PR |
issue: #33285