Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: all op(Null) is false in expr #35527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

enhance: all op(Null) is false in expr #35527

wants to merge 3 commits into from
+12,948 −4,290

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Aug 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 16, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.10219% with 150 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (1833913) to head (6c93c57).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/Expr.h 50.00% 42 Missing ⚠️
internal/core/src/segcore/Utils.cpp 44.44% 35 Missing ⚠️
internal/core/src/exec/expression/CompareExpr.cpp 68.29% 13 Missing ⚠️
...src/exec/expression/BinaryArithOpEvalRangeExpr.cpp 86.51% 12 Missing ⚠️
internal/core/src/exec/expression/TermExpr.cpp 86.95% 6 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 92.75% 5 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.h 82.75% 5 Missing ⚠️
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 86.66% 4 Missing ⚠️
...nternal/core/src/exec/expression/BinaryRangeExpr.h 82.60% 4 Missing ⚠️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 93.44% 4 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35527      +/-   ##
==========================================
+ Coverage   73.42%   82.30%   +8.87%     
==========================================
  Files        1277     1277              
  Lines      150832   151248     +416     
==========================================
+ Hits       110749   124483   +13734     
+ Misses      35110    21780   -13330     
- Partials     4973     4985      +12
Files with missing lines Coverage Δ
internal/core/src/common/Vector.h 100.00% <100.00%> (+93.33%) ⬆️
...ternal/core/src/exec/expression/AlwaysTrueExpr.cpp 85.71% <100.00%> (+85.71%) ⬆️
internal/core/src/exec/expression/CompareExpr.h 77.77% <100.00%> (+77.77%) ⬆️
internal/core/src/exec/expression/ExistsExpr.cpp 86.66% <100.00%> (+86.66%) ⬆️
...rnal/core/src/exec/expression/LogicalUnaryExpr.cpp 100.00% <100.00%> (+100.00%) ⬆️
internal/core/src/exec/operator/FilterBitsNode.cpp 96.07% <100.00%> (+96.07%) ⬆️
internal/core/src/index/BitmapIndex.h 55.55% <ø> (+55.55%) ⬆️
internal/core/src/index/ScalarIndex.h 27.77% <ø> (+25.00%) ⬆️
internal/core/src/index/ScalarIndexSort.h 42.85% <ø> (ø)
internal/core/src/index/StringIndexMarisa.cpp 65.47% <100.00%> (+65.47%) ⬆️
... and 22 more

... and 210 files with indirect coverage changes

@smellthemoon smellthemoon force-pushed the expr-null-1 branch 3 times, most recently from 04aa42e to 030304b Compare August 27, 2024 06:10
@tedxu
Copy link
Collaborator

tedxu commented Aug 27, 2024

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot removed the ci-passed label Aug 27, 2024
@sre-ci-robot sre-ci-robot removed the lgtm label Aug 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 28, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Aug 28, 2024
@tedxu
Copy link
Collaborator

tedxu commented Aug 29, 2024

/lgtm

@smellthemoon smellthemoon mentioned this pull request Sep 9, 2024
Open
1 task
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 12, 2024
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify mergify bot removed the ci-passed label Sep 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 12, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon smellthemoon force-pushed the expr-null-1 branch 2 times, most recently from 7f8fd1a to 450404c Compare September 13, 2024 05:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

lixinguo added 3 commits September 23, 2024 22:33
enhance: all op(Null) is false in expr
5066aad 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
store valid bitset and add test in not expr
0d59c8b 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
fix conflict
6c93c57 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 23, 2024
This was referenced Sep 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@tedxu tedxu

Labels
area/compilation area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smellthemoon @tedxu @sre-ci-robot