Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enable asan for milvus #35627

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Aug 21, 2024

issue: #35626

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/compilation labels Aug 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (59387f0) to head (f6c521f).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #35627       +/-   ##
===========================================
- Coverage   84.69%   72.38%   -12.31%     
===========================================
  Files         959     1237      +278     
  Lines      123242   147654    +24412     
===========================================
+ Hits       104375   106875     +2500     
- Misses      14111    36024    +21913     
+ Partials     4756     4755        -1     

see 310 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_enable_asan_build_milvus branch from e2b653a to 37b53da Compare August 22, 2024 05:20
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 22, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 22, 2024
@chyezh chyezh force-pushed the enhance_enable_asan_build_milvus branch 2 times, most recently from a14facf to 56a0d7f Compare August 22, 2024 13:16
@mergify mergify bot added the ci-passed label Aug 22, 2024
@chyezh chyezh force-pushed the enhance_enable_asan_build_milvus branch from 56a0d7f to 9b93480 Compare August 23, 2024 06:16
@mergify mergify bot removed the ci-passed label Aug 23, 2024
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the enhance_enable_asan_build_milvus branch from 9b93480 to f6c521f Compare August 23, 2024 06:17
@mergify mergify bot added the ci-passed label Aug 23, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 75da36d into milvus-io:master Aug 23, 2024
14 of 16 checks passed
@chyezh chyezh deleted the enhance_enable_asan_build_milvus branch August 23, 2024 13:08
chyezh added a commit to chyezh/milvus that referenced this pull request Aug 24, 2024
issue: milvus-io#35626

Signed-off-by: chyezh <chyezh@outlook.com>
chyezh added a commit to chyezh/milvus that referenced this pull request Aug 25, 2024
issue: milvus-io#35626

Signed-off-by: chyezh <chyezh@outlook.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 26, 2024
issue: #35626
pr: #35627

Signed-off-by: chyezh <chyezh@outlook.com>
chyezh added a commit to chyezh/milvus that referenced this pull request Aug 28, 2024
issue: milvus-io#35626

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants