Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rename preAllocatedSegments #35871

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

bigsheeper
Copy link
Contributor

Rename preAllocatedSegments to preAllocatedSegmentIDs to avoid confusion.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.40%. Comparing base (311f860) to head (cd7ded0).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/services.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35871      +/-   ##
==========================================
+ Coverage   79.84%   81.40%   +1.55%     
==========================================
  Files        1239     1252      +13     
  Lines      148031   149322    +1291     
==========================================
+ Hits       118194   121554    +3360     
+ Misses      25005    22906    -2099     
- Partials     4832     4862      +30     
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_clustering.go 79.68% <100.00%> (+2.60%) ⬆️
internal/datacoord/compaction_task_mix.go 64.25% <100.00%> (+7.23%) ⬆️
...ternal/datanode/compaction/clustering_compactor.go 67.45% <100.00%> (+2.25%) ⬆️
internal/datanode/compaction/mix_compactor.go 77.12% <100.00%> (+3.92%) ⬆️
internal/datanode/services.go 85.94% <50.00%> (+12.43%) ⬆️

... and 223 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Sep 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1413ffe into milvus-io:master Sep 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants