Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] fill the metric type field in the LoadMetaInfo object #35963

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 4, 2024
@czs007
Copy link
Contributor

czs007 commented Sep 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 4, 2024
@sre-ci-robot sre-ci-robot merged commit 084b3ef into milvus-io:2.4 Sep 4, 2024
12 of 13 checks passed
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (4fdd4d9) to head (8a359f9).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35963      +/-   ##
==========================================
+ Coverage   81.14%   84.99%   +3.85%     
==========================================
  Files        1057      790     -267     
  Lines      139419   114795   -24624     
==========================================
- Hits       113133    97574   -15559     
+ Misses      21992    12945    -9047     
+ Partials     4294     4276      -18     
Files with missing lines Coverage Δ
internal/querycoordv2/task/executor.go 80.20% <100.00%> (-1.35%) ⬇️

... and 310 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants