Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: reduce mmap_rss after chunkcache warmup #35974

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cqy123456
Copy link
Contributor

related pr: #35965

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (919e96a) to head (f465e3c).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/ChunkCache.cpp 14.28% 6 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35974      +/-   ##
==========================================
- Coverage   85.01%   81.55%   -3.46%     
==========================================
  Files         984     1265     +281     
  Lines      125923   150477   +24554     
==========================================
+ Hits       107048   122724   +15676     
- Misses      13980    22880    +8900     
+ Partials     4895     4873      -22     
Files with missing lines Coverage Δ
internal/core/src/storage/ChunkCache.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 75.95% <0.00%> (ø)
internal/core/src/storage/ChunkCache.cpp 55.43% <14.28%> (ø)

... and 312 files with indirect coverage changes

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@bigsheeper
Copy link
Contributor

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Sep 5, 2024
related pr: #35974

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Sep 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 560e8e7 into milvus-io:master Sep 5, 2024
14 of 16 checks passed
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
related pr: milvus-io#35965

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants