Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Fix trace.cpp lint format issue #36004

Merged

Conversation

congqixia
Copy link
Contributor

Introduced by #35928

Introduced by milvus-io#35928

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Sep 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 5, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Sep 5, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c61eea7 into milvus-io:master Sep 5, 2024
8 of 10 checks passed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (7b21032) to head (e51de9e).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Tracer.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36004      +/-   ##
==========================================
- Coverage   81.59%   72.62%   -8.98%     
==========================================
  Files        1266     1266              
  Lines      150648   150665      +17     
==========================================
- Hits       122924   109423   -13501     
- Misses      22853    36364   +13511     
- Partials     4871     4878       +7     
Files with missing lines Coverage Δ
internal/core/src/common/Tracer.cpp 0.00% <0.00%> (-77.78%) ⬇️

... and 235 files with indirect coverage changes

@congqixia congqixia deleted the enhance/fix_tracer_cpp_lint branch September 5, 2024 10:41
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
Introduced by milvus-io#35928

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants