Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BinlogDeserializeReader leak #36087

Merged

Conversation

fengjun2016
Copy link
Contributor

Signed-off-by: fengjun2016 <jornfeng@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (7859faf) to head (218eaaa).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
internal/indexnode/task_stats.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36087      +/-   ##
==========================================
+ Coverage   72.62%   81.58%   +8.96%     
==========================================
  Files        1266     1266              
  Lines      150757   150760       +3     
==========================================
+ Hits       109485   123004   +13519     
+ Misses      36395    22880   -13515     
+ Partials     4877     4876       -1     
Files with missing lines Coverage Δ
internal/indexnode/task_stats.go 77.03% <50.00%> (+0.69%) ⬆️

... and 241 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@xiaofan-luan
Copy link
Contributor

good catch! man you are so good at it!

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengjun2016, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4850641 into milvus-io:master Sep 10, 2024
15 of 16 checks passed
@fengjun2016 fengjun2016 deleted the bugfix/fix-resource-release-1 branch September 10, 2024 06:41
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
milvus-io#36086

Signed-off-by: fengjun2016 <jornfeng@gmail.com>
@fengjun2016
Copy link
Contributor Author

good catch! man you are so good at it!

Thank you for your compliment.
It’s just that in my daily work, I have accumulated a little sensitivity in the process of code review and a little bit of mysophobia about the code.
Of course, too much mysophobia about the code is not always a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants