enhance: Filter out non-hit delete records during load delta #36207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#35303 This PR utilizes pk index in segment to exclude non-hit delete record during load delete records. This ability is crucial when l0/delete forward policy only replies on segment itself(without BF filtering). Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
changed the title
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36207 +/- ##
===========================================
+ Coverage 72.31% 84.77% +12.45%
===========================================
Files 1276 994 -282
Lines 152054 126887 -25167
===========================================
- Hits 109965 107567 -2398
+ Misses 37153 14381 -22772
- Partials 4936 4939 +3 |
tedxu
reviewed
Sep 13, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Sep 14, 2024
…io#36207) Related to milvus-io#35303 This PR utilizes pk index in segment to exclude non-hit delete record during load delete records. This ability is crucial when l0/delete forward policy only replies on segment itself(without BF filtering). --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This was referenced Sep 14, 2024
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 19, 2024
…36207) (#36272) Cherry-pick from master pr: #36207 Related to #35303 This PR utilizes pk index in segment to exclude non-hit delete record during load delete records. This ability is crucial when l0/delete forward policy only replies on segment itself(without BF filtering). --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #35303
This PR utilizes pk index in segment to exclude non-hit delete record during load delete records. This ability is crucial when l0/delete forward policy only replies on segment itself(without BF filtering).