Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add streaming forward policy switch for delegator #36330

Merged

Conversation

congqixia
Copy link
Contributor

Related to #35303

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Sep 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 65.81633% with 67 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (eb23e23) to head (dc97632).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/delegator/delta_forward.go 63.97% 61 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36330   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files        1277     1277           
  Lines      150744   150825   +81     
=======================================
+ Hits       124126   124195   +69     
- Misses      21632    21645   +13     
+ Partials     4986     4985    -1     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator_data.go 86.56% <100.00%> (+1.38%) ⬆️
internal/querynodev2/delegator/scalar_pruner.go 87.32% <ø> (ø)
pkg/util/paramtable/component_param.go 98.30% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/delegator/delta_forward.go 63.97% <63.97%> (ø)

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 18, 2024
Related to milvus-io#35303

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia force-pushed the enhance/add_streaming_forward_policy branch from 7f11802 to dc97632 Compare September 23, 2024 07:07
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 23, 2024
@mergify mergify bot removed the ci-passed label Sep 23, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 23, 2024
@sre-ci-robot sre-ci-robot merged commit 1833913 into milvus-io:master Sep 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants