Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add openai embedding #36366

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: Add openai embedding #36366

wants to merge 3 commits into from
+1,293 −0

Conversation

junjiejiangjjj
Copy link

@junjiejiangjjj junjiejiangjjj commented Sep 19, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Sep 19, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junjiejiangjjj
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

Welcome @junjiejiangjjj! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Sep 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

@junjiejiangjjj Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@junjiejiangjjj junjiejiangjjj mentioned this pull request Sep 19, 2024
Open
1 task
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 23, 2024
@junjiejiangjjj
Add openai embedding client
336a362 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Add embedding runner
ed7d332 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 26, 2024
@junjiejiangjjj
Add function executor
44d42e3 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees
No one assigned
Labels
dco-passed DCO check passed. do-not-merge/work-in-progress Don't merge even CI passed. kind/feature Issues related to feature request from users size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junjiejiangjjj @sre-ci-robot