Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio/x-aac was deprecated in favour of audio/aac. #77

Closed
wants to merge 1 commit into from

Conversation

ioquatix
Copy link

@ioquatix ioquatix commented Jun 30, 2024

Copy link
Member

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge this, as audio/aac is already defined as a registered type (audio.yaml:42).

Historically, audio/x-aac could still be returned and it should be able to be looked up. A better change would be to remove the extensions from audio/x-aac and add them to audio/aac so that is returned instead on extension lookup. There are probably more than a few cases where this would be the case, but the last time I checked this (it was a couple of years ago), the official IANA sources do not usually define filename extensions in the MIME type declaration, but they may be in the RFC. I don't have time to read all of the RFCs involved.

@ioquatix
Copy link
Author

ioquatix commented Jul 1, 2024

That makes sense.

@ioquatix
Copy link
Author

ioquatix commented Jul 1, 2024

Can you check this is the correct change?

@ioquatix ioquatix requested a review from halostatue July 1, 2024 06:00
halostatue added a commit that referenced this pull request Jul 2, 2024
- Moved extensions from `audio/x-aac` to `audio/aac` and mark
  `audio/x-aac` as obsolete.

  - Made the same changes for `audio/flac` and `audio/matroska`.

Closes: #77
@halostatue halostatue closed this in 75bde6b Jul 2, 2024
@halostatue
Copy link
Member

Today was the data update day, so I made the changes on top of #79 and will be releasing it momentarily.

@ioquatix
Copy link
Author

ioquatix commented Jul 2, 2024

Thanks @halostatue appreciate your time and efforts!

@ioquatix ioquatix deleted the audio-x-aac branch July 2, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants