Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements stream.finished() for better error handling. #8

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Implements stream.finished() for better error handling. #8

merged 1 commit into from
Nov 11, 2019

Conversation

leodutra
Copy link
Contributor

@leodutra leodutra commented Nov 5, 2019 •
edited
Loading

Reason: ClientRequest emits 'aborted', but it was not being handled (more).

@minhnhut
Copy link
Owner

minhnhut commented Nov 6, 2019

Thanks, I will test this out.

@leodutra
Copy link
Contributor Author

leodutra commented Nov 6, 2019

Yeah, I ran your test and did some local testing, but tests are never enough.
Thank you for checking.

@minhnhut minhnhut merged commit b613c9b into minhnhut:master Nov 11, 2019
@minhnhut
Copy link
Owner

It is working well.
Thank you very much for PR.

@leodutra
Copy link
Contributor Author

Thank you for this useful lib.

@leodutra leodutra deleted the ClientRequest-error-guarding branch November 11, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodutra @minhnhut