Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added endpoint and version attributes to KMS details #4591

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

shtripat
Copy link
Contributor

@shtripat shtripat commented Jun 5, 2023

Description

Now it would list details of all KMS instances with additional attributes endpoint and version. In case of k8s based deployment the list would consist a single entry.

Motivation and Context

In case there are multiple instances of KES deployed and they have different versions, this would make sure details are listed at instance level.

How to test this PR?

mc admin info ALIAS --json should show .info.services.kmsStatus as below

$ ./mc admin info myminio --json | jq '.info.services.kmsStatus'
[
  {
    "status": "online",
    "encrypt": "success",
    "decrypt": "success",
    "endpoint": "https://127.0.0.1:7373",
    "version": "2023-05-11T04-04-40Z"
  },
  {
    "status": "online",
    "encrypt": "success",
    "decrypt": "success",
    "endpoint": "https://127.0.0.1:7474",
    "version": "2023-05-11T04-04-40Z"
  }
]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@shtripat shtripat marked this pull request as ready for review June 5, 2023 04:43
@shtripat shtripat force-pushed the kms-versions branch 2 times, most recently from a13c948 to fbebad9 Compare June 27, 2023 12:18
@shtripat shtripat force-pushed the kms-versions branch 2 times, most recently from 00d4bf9 to 5012192 Compare July 7, 2023 15:26
Now it would list details of all KMS instances with additional attributes
endpoint and version. In case of k8s based deployment the list would consist
a single entry.

Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
@harshavardhana harshavardhana merged commit 15ea112 into minio:master Jul 13, 2023
5 checks passed
bjw-s referenced this pull request in bjw-s/dotfiles Jul 19, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [mc](https://togithub.com/minio/mc) | patch | `2023-07-11T23-30-44Z`
-> `2023-07-18T21-05-38Z` |

---

### Release Notes

<details>
<summary>minio/mc (mc)</summary>

###
[`v2023-07-18T21-05-38Z`](https://togithub.com/minio/mc/releases/tag/RELEASE.2023-07-18T21-05-38Z):
Bug Fix Release

[Compare
Source](https://togithub.com/minio/mc/compare/RELEASE.2023-07-11T23-30-44Z...RELEASE.2023-07-18T21-05-38Z)

##### What's Changed

- allow purge to happen on quorum lost objects by
[@&#8203;harshavardhana](https://togithub.com/harshavardhana) in
[https://github.com/minio/mc/pull/4629](https://togithub.com/minio/mc/pull/4629)
- Rename mc replicate diff as mc replicate backlog by
[@&#8203;poornas](https://togithub.com/poornas) in
[https://github.com/minio/mc/pull/4568](https://togithub.com/minio/mc/pull/4568)
- Added `endpoint` and `version` attributes to KMS details by
[@&#8203;shtripat](https://togithub.com/shtripat) in
[https://github.com/minio/mc/pull/4591](https://togithub.com/minio/mc/pull/4591)
- Ensure `--airgap` is available on all support commands by
[@&#8203;anjalshireesh](https://togithub.com/anjalshireesh) in
[https://github.com/minio/mc/pull/4633](https://togithub.com/minio/mc/pull/4633)
- run gofumpt -extra on all source files by
[@&#8203;harshavardhana](https://togithub.com/harshavardhana) in
[https://github.com/minio/mc/pull/4634](https://togithub.com/minio/mc/pull/4634)
- Fixing misleading usage help for mc anonymous set-json by
[@&#8203;mesif](https://togithub.com/mesif) in
[https://github.com/minio/mc/pull/4621](https://togithub.com/minio/mc/pull/4621)
- Support mc top net by [@&#8203;jiuker](https://togithub.com/jiuker) in
[https://github.com/minio/mc/pull/4626](https://togithub.com/minio/mc/pull/4626)
- fix: with --purge flag ignore path validation errors by
[@&#8203;harshavardhana](https://togithub.com/harshavardhana) in
[https://github.com/minio/mc/pull/4636](https://togithub.com/minio/mc/pull/4636)

##### New Contributors

- [@&#8203;mesif](https://togithub.com/mesif) made their first
contribution in
[https://github.com/minio/mc/pull/4621](https://togithub.com/minio/mc/pull/4621)

**Full Changelog**:
minio/mc@RELEASE.2023-07-11T23-30-44Z...RELEASE.2023-07-18T21-05-38Z

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMC4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants