Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail mc-admin-policy-attach if policy already attached/detached #5058

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

dhananjaykrutika
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

mc admin policy attach of a policy that has been already assigned to a user should succeed.
Same with detach.

Motivation and Context

Currently, attempts to attach a policy to a user who already has the policy attached to them results in a 400.

This change is to handle cases where policy attach/detach operations are automated using scripts/jobs. A re-run of the attach/detach step should not result in the failure of the entire job.

How to test this PR?

Attach a policy to a user using mc admin policy attach ...
Attach the same policy again. The command should succeed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Currently, attempts to attach a policy to a user who already has
the policy attached to them results in a 400.

This change is to handle cases where policy attach/detach operations
are automated using scripts/jobs. A re-run of the attach/detach
step should not result in the failure of the entire job.
@shtripat
Copy link
Contributor

shtripat commented Oct 8, 2024

Fix the lint failures

cmd/admin-policy-attach.go:27: File is not `gofmt`-ed with `-s` (gofmt)
    errCodeChangeAlreadyApplied = "XMinioAdminPolicyChangeAlreadyApplied"
cmd/admin-policy-attach.go:83: File is not `gofumpt`-ed (gofumpt)
    return false
make: *** [Makefile:43: lint] Error 1

@shtripat
Copy link
Contributor

shtripat commented Oct 8, 2024

Is it fine to suppress this error only in client side? Server still sends a 400 response for this and we are ignoring in client side.

@dhananjaykrutika
Copy link
Contributor Author

@shtripat , the error is being handled in mc so that the fix can work with older versions of minio servers as well.

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/admin-policy-attach.go Outdated Show resolved Hide resolved
cmd/admin-policy-attach.go Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit cf128de into master Oct 8, 2024
5 checks passed
@harshavardhana harshavardhana deleted the allow-reattaching-policies branch October 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants