Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRS-2058 Changing from stepper to sub nav style pages #786

Merged
merged 4 commits into from
Aug 7, 2024
Merged

CRS-2058 Changing from stepper to sub nav style pages #786

merged 4 commits into from
Aug 7, 2024

Conversation

FaizJD030
Copy link
Contributor

@FaizJD030 FaizJD030 marked this pull request as ready for review August 7, 2024 13:34
@FaizJD030 FaizJD030 requested a review from a team as a code owner August 7, 2024 13:34
srowlands-moj
srowlands-moj previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@srowlands-moj srowlands-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments - otherwise LGTM

integration_tests/pages/viewCalculationSummary.ts Outdated Show resolved Hide resolved
integration_tests/pages/viewSentencesAndOffences.ts Show resolved Hide resolved
srowlands-moj
srowlands-moj approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@srowlands-moj srowlands-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaizJD030 FaizJD030 merged commit b12cdfd into main Aug 7, 2024
4 checks passed
@FaizJD030 FaizJD030 deleted the CRS-2058-View-Route-SubNav branch August 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowlands-moj srowlands-moj srowlands-moj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FaizJD030 @srowlands-moj